feat: new checkstyle version.

GumTreeDiff · Jun 5, 2024 · 6544af8 · 6544af8
1 parent f9c6d21
commit 6544af8
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 7 deletions.
diff --git a/build.gradle b/build.gradle
@@ -43,7 +43,6 @@ subprojects {
 
     apply plugin: 'checkstyle'
     checkstyle {
-        toolVersion = '8.36'
         configFile = rootProject.file('gumtree_checkstyle.xml')
         configProperties = [suppressionFile: "${rootProject.file('checkstyle_ignore.xml')}"]
         ignoreFailures = false

diff --git a/core/src/main/java/com/github/gumtreediff/matchers/GumtreeProperties.java b/core/src/main/java/com/github/gumtreediff/matchers/GumtreeProperties.java
@@ -43,8 +43,7 @@ public Object get(ConfigurationOptions option) {
      * as argument
      *
      * @param propertyName name of the property to check
-     * @param value        value to put in properties if the name does not exist.
-     * @return
+     * @param value value to put in properties if the name does not exist.
      */
     private Object setIfNotPresent(String propertyName, Object value) {
         if (!properties.containsKey(propertyName)) {

diff --git a/core/src/main/java/com/github/gumtreediff/matchers/Matchers.java b/core/src/main/java/com/github/gumtreediff/matchers/Matchers.java
@@ -32,7 +32,6 @@ public class Matchers extends Registry<String, Matcher, Register> {
 
     /**
      * Return the matcher registry instance (singleton pattern).
-     * @return
      */
     public static Matchers getInstance() {
         if (registry == null)

diff --git a/core/src/main/java/com/github/gumtreediff/matchers/heuristic/gt/MappingComparators.java b/core/src/main/java/com/github/gumtreediff/matchers/heuristic/gt/MappingComparators.java
@@ -91,13 +91,13 @@ public int compare(Mapping m1, Mapping m2) {
                 return 0;
 
             if (!cachedSimilarities.containsKey(m1))
-            cachedSimilarities.put(m1, SimilarityMetrics.diceCoefficient(commonDescendantsNb(m1.first.getParent(),
+                cachedSimilarities.put(m1, SimilarityMetrics.diceCoefficient(commonDescendantsNb(m1.first.getParent(),
                         m1.second.getParent()),
                         srcDescendants.get(m1.first.getParent()).size(),
                         dstDescendants.get(m1.second.getParent()).size()));
 
             if (!cachedSimilarities.containsKey(m2))
-            cachedSimilarities.put(m2, SimilarityMetrics.diceCoefficient(commonDescendantsNb(m2.first.getParent(),
+                cachedSimilarities.put(m2, SimilarityMetrics.diceCoefficient(commonDescendantsNb(m2.first.getParent(),
                         m2.second.getParent()),
                         srcDescendants.get(m2.first.getParent()).size(),
                         dstDescendants.get(m2.second.getParent()).size()));

diff --git a/core/src/main/java/com/github/gumtreediff/tree/Tree.java b/core/src/main/java/com/github/gumtreediff/tree/Tree.java
@@ -92,7 +92,7 @@ default Tree getChild(int position) {
      * Return trees contained in a text positions interval
      * @param position the begin position
      * @param endPosition the end position (must be greater than position)
-     * @return
+     * @return the list of trees contained in the interval, possibly empty
      */
     default List<Tree> getTreesBetweenPositions(int position, int endPosition) {
         List<Tree> trees = new ArrayList<>();