Refactor CSS to SCSS #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transfer: - Buttons - Base styles - Add some mixins - Add header styles to SCSS
|
(BTW the REPL.IT user is me) |
|
Got to line 490 |
Create tabs.scss Mobile headers
|
Got to line 553 |
Copy and sort tabs CSS.
Add new mixin for fully centered flex items & migrate SCSS to it
Thank you @Asametric for your suggested fix! The fix of `position: absolute` on the tab row was applied for small screen sizes (on desktop things became a bit too spaced out)
Take year group calendar offline
|
Only thing outstanding is #60 |
ILikeTeaALot
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor CSS to SCSS so it is more manageable.
Fixes #44.
TODO: