MS1.5 Fix an issue where the site is wrong #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILikeTeaALot
approved these changes
Feb 28, 2021
Gum-Joe
added a commit
that referenced
this pull request
Mar 2, 2021
Fix #50 to ensure the site works: Issue was that we told the site to go forward 1 week on Sundays and Saturdays, which resulted in it skipping a week forward. This is because the algorithm works by rewinding to the last Sunday and going from there, so on Sundays it obviously stays on the current Sunday, and it was programmed to jump forward 7 days on Sundays Also adds a alert on Lateral Flow Testing & version bump Commits: * Change alert * Setup separate KECHG and KECHB alerts * Fixed an issue where date was wrong #50 Added alerts to holiday page * Bump version number * Remove date fiddling
Gum-Joe
added a commit
that referenced
this pull request
Mar 2, 2021
* Add new build script Co-authored-by: David Wheatley <hi@davwheat.dev> * Reduce colours on homepage (#43) Reduce the number of colours on the homepage, by: - Changing social to minimal icons with no coloured BG (only have a white outline now) - Modify some colours for alerts * Iteration 1: socials * Change hover for socials * Bump version number * Add code docs * Slightly darken green * Adjust blue used for INFO * MS1.5 Fix an issue where the site is wrong (#51) Fix #50 to ensure the site works: Issue was that we told the site to go forward 1 week on Sundays and Saturdays, which resulted in it skipping a week forward. This is because the algorithm works by rewinding to the last Sunday and going from there, so on Sundays it obviously stays on the current Sunday, and it was programmed to jump forward 7 days on Sundays Also adds a alert on Lateral Flow Testing & version bump Commits: * Change alert * Setup separate KECHG and KECHB alerts * Fixed an issue where date was wrong #50 Added alerts to holiday page * Bump version number * Remove date fiddling * Testing * Add env vars * Correct build path * Readd branch protector Remove 6th form quiz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50 to ensure the site works.
Issue was that we told the site to go forward 1 week on Sundays and Saturdays, which resulted in it skipping a week forward. This is because the algorithm works by rewinding to the last Sunday and going from there, so on Sundays it obviously stays on the current Sunday, and it was programmed to jump forward 7 days on Sundays