Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #15 #17

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Attempt to fix #15 #17

merged 2 commits into from
Jun 25, 2019

Conversation

Gum-Joe
Copy link
Owner

@Gum-Joe Gum-Joe commented Jun 25, 2019

After #15 was filed, some investigation was conducted, finding:

  1. The 2Keys global install is broken
  2. The 2Keys source build is broken

This PR attempts to fix that.
Regarding 1., it appears C++ source code was not packaged. This has been attempted to be resolved.

Added src/cpp to tarball
Source build now works, as TS file problems have been tidied!
@Gum-Joe
Copy link
Owner Author

Gum-Joe commented Jun 25, 2019

Some testing shows this now works (or at least, nothing broke!)
NPM package should now include C++ SRC
TS definitions fixed so source builds
Added instructions on how to build using new yarn script

@Gum-Joe Gum-Joe merged commit 042c07f into master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant