Create a new pull request by comparing #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora's script tries to coerce all shebangs to point to exact, system-provided binaries. For example: `#!/usr/bin/env sh` becomes `#!/usr/bin/sh`. Starting with Fedora 30, the script errors out when it encounters ambiguous, versionless `python` in shebangs. (`python2` and `python3` are allowed.) For example, this shebang causes an error: `#!/usr/bin/env python`. --- Disable this script for two reasons: 1) Fedora users should be able to build Atom without errors. 2) Consistent shebangs across builds of Atom on Ubuntu and Fedora. See: #21937 for more details. Fixes: #21937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚛👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.