Fix hex conversion with alpha #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
May 30, 2023
…lor-9, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. The `browser-ui-test` update is a fix when converting the alpha value to hex format. More information [here](GuillaumeGomez/browser-UI-test#511). r? `@notriddle`
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
May 30, 2023
…lor-9, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. The `browser-ui-test` update is a fix when converting the alpha value to hex format. More information [here](GuillaumeGomez/browser-UI-test#511). r? ``@notriddle``
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
May 30, 2023
…lor-9, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. The `browser-ui-test` update is a fix when converting the alpha value to hex format. More information [here](GuillaumeGomez/browser-UI-test#511). r? ```@notriddle```
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
May 30, 2023
…lor-9, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. The `browser-ui-test` update is a fix when converting the alpha value to hex format. More information [here](GuillaumeGomez/browser-UI-test#511). r? ````@notriddle````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funny case where
rgba(255, 236, 164, 0.06)was converted into#ffeca4f.4ccccccccccc8. A rounding was missing.