Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEAR check mode for assert-(variable|property|document-property|window-property|attribute) #432

Merged

Conversation

notriddle
Copy link
Contributor

No description provided.

@notriddle notriddle force-pushed the notriddle/near-check branch from c3c528a to f09fda3 Compare January 15, 2023 22:49
@notriddle
Copy link
Contributor Author

This is a fix for a floating-point bug that I managed to stumble upon in rust-lang/rust#106915

r? @GuillaumeGomez

@notriddle notriddle changed the title Add NEAR check mode for assert-(variable|property|document-property|window-property) Add NEAR check mode for assert-(variable|property|document-property|window-property|attribute) Jan 15, 2023
@GuillaumeGomez
Copy link
Owner

This is a nice add, thanks! We could also maybe add it for css variables (for things like font-size comparison). We can parse like this:

Number.parseFloat("12.2px", 10)

But that can be done at a later time. :)

@GuillaumeGomez GuillaumeGomez merged commit 16397fc into GuillaumeGomez:master Jan 16, 2023
@notriddle notriddle deleted the notriddle/near-check branch January 16, 2023 14:31
@notriddle
Copy link
Contributor Author

@GuillaumeGomez Can you push a new version, please?

@GuillaumeGomez
Copy link
Owner

Yes! Doing something else currently but I'll make a release in the next hour or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants