Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secondary badge variant #89

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Add secondary badge variant #89

merged 1 commit into from
Jul 29, 2020

Conversation

jscheel
Copy link
Contributor

@jscheel jscheel commented Jul 28, 2020

No description provided.

@jscheel jscheel added enhancement New feature or request patch Increment the patch version when merged release Create a release when this pr is merged labels Jul 28, 2020
@jscheel
Copy link
Contributor Author

jscheel commented Jul 28, 2020

Add in close button to Groove Widget (would be awesome if we can make this a javascript function to show as it would be really valuable for customers too) (0.5)

@jscheel jscheel requested review from assimovt and kevinrademan and removed request for assimovt July 28, 2020 14:15
kevinrademan
kevinrademan approved these changes Jul 29, 2020
View reviewed changes
src/components/Badge.js
/**
* Specify variant
*/
variant: PropTypes.oneOf(['primary', 'secondary']),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick
Perhaps this should rather be "primary" (primary indicating the primary color is used) and "light" (indicating that white colors are getting used). Primary and secondary might be ok for now, but it gets less and less useful as we start adding more variations and it doesnt really hint what make the variant different

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I was trying to match the button props, since the badge is really a glorified button.

@jscheel jscheel merged commit ee0f613 into master Jul 29, 2020
@jscheel jscheel deleted the secondary-badge branch July 29, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrademan kevinrademan kevinrademan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jscheel @kevinrademan