Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable proptype for AvatarList children #83

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Disable proptype for AvatarList children #83

merged 1 commit into from
Jun 17, 2020

Conversation

jscheel
Copy link
Contributor

@jscheel jscheel commented Jun 15, 2020

This proptype causes a react hooks error for some reason.

@jscheel
Disable proptype for AvatarList children
dba97ab 
This proptype causes a react hooks error for some reason.
@jscheel jscheel added bug Something isn't working internal Changes only affect the internal API patch Increment the patch version when merged release Create a release when this pr is merged labels Jun 15, 2020
@jscheel jscheel requested a review from assimovt June 15, 2020 03:21
assimovt
assimovt approved these changes Jun 15, 2020
View reviewed changes
Copy link

@assimovt assimovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh 😝 Maybe let's create an issue to tackle it later

@jscheel jscheel merged commit 43552b8 into master Jun 17, 2020
@jscheel jscheel deleted the fix-hook-error-from-proptype branch June 17, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assimovt assimovt assimovt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal Changes only affect the internal API patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jscheel @assimovt