Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor badge #80

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Refactor badge #80

merged 1 commit into from
Jun 8, 2020

Conversation

jscheel
Copy link
Contributor

@jscheel jscheel commented Jun 1, 2020

  • Fix issue where controlled/uncontrolled state becomes out of sync
  • Clean up icon animations
  • Add support for onAnimationComplete
  • Fix text overflow
  • Fix reverse icon/text order
  • Fix text width animation
  • Fix unread count positioning
  • Limit unread count to 99+

@jscheel
Refactor badge
aa6f070 
- Fix issue where controlled/uncontrolled state becomes out of sync
- Clean up icon animations
- Add support for onAnimationComplete
- Fix text overflow
- Fix reverse icon/text order
- Fix text width animation
- Fix unread count positioning
- Limit unread count to 99+
@jscheel jscheel requested a review from assimovt June 1, 2020 18:22
@jscheel jscheel added bug Something isn't working enhancement New feature or request patch Increment the patch version when merged release Create a release when this pr is merged labels Jun 1, 2020
@jscheel
Copy link
Contributor Author

jscheel commented Jun 1, 2020

fix open command not updating badge (0.2)

assimovt
assimovt approved these changes Jun 2, 2020
View reviewed changes
Copy link

@assimovt assimovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@jscheel jscheel merged commit c3742ef into master Jun 8, 2020
@jscheel jscheel deleted the refactor-badge branch June 8, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assimovt assimovt assimovt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jscheel @assimovt