Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style of links in the Header component #14

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

assimovt
Copy link

@assimovt assimovt commented Dec 5, 2019

If links are placed within header, we need to style them according to our design system: a bit of hover opacity + text-decoration on span/divs, which are used in the Heading/Paragraph components.

@assimovt assimovt requested a review from kevinrademan December 5, 2019 11:39
@assimovt assimovt added the patch Increment the patch version when merged label Dec 5, 2019
Copy link
Contributor

@kevinrademan kevinrademan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@assimovt assimovt merged commit be6eb83 into master Dec 9, 2019
@assimovt assimovt deleted the fix-cpnt-header-links branch December 9, 2019 09:53
@assimovt assimovt added the release Create a release when this pr is merged label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants