Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge with master #5

Merged
merged 36 commits into from
Sep 19, 2018
Merged

Merge with master #5

merged 36 commits into from
Sep 19, 2018

Commits on Sep 14, 2018

  1. chainparams: Add max_funding_satoshi and max_payment_msat to chainparams

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    8d95917 View commit details
    Browse the repository at this point in the history

  2. channeld: Keep track of the chainparams for the chain we are using

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    2402c52 View commit details
    Browse the repository at this point in the history

  3. channeld: Use the chainparams to check msatoshi and funding_satoshi

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    0128bc7 View commit details
    Browse the repository at this point in the history

  4. chainparams: Move the BOLT2 quote to the chainparams where we set it

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    2d7e603 View commit details
    Browse the repository at this point in the history

  5. chainparams: Always retrieve chainparams by the chain_hash

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    f417dfa View commit details
    Browse the repository at this point in the history

  6. chainparams: Remove index from chainparams 

    We no longer use it to reference chainparams, so we can remove it completely.
    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    e10cde3 View commit details
    Browse the repository at this point in the history

  7. channeld: Do not fail if we get a chain_hash we don't know

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    dc88c35 View commit details
    Browse the repository at this point in the history

  8. master: Move JSON-RPC setup below PID-file creation 

    If we run two daemons on the same directory we'd be getting the failure from
trying to listen to the same file before we'd hit the pid-file error, which was
causing confusion.
    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    d9ea2e6 View commit details
    Browse the repository at this point in the history

  9. docker: Add missing dependencies to builder for a2x

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    b861e44 View commit details
    Browse the repository at this point in the history

  10. pytest: Keep the test directory even if the failure is in the fixtures

    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    79da1b9 View commit details
    Browse the repository at this point in the history

  11. pytest: Fix flaky test_logging 

    File was rotated away but didn't wait for the first line to be actually written.
    @cdecker
    cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    f1e931f View commit details
    Browse the repository at this point in the history

  12. lightningd: split pidfile handling. 

    We want to try it before --daemon, in case we error, but we don't know
the pid yet, so we split into 'lock' and 'write'.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    bdb8416 View commit details
    Browse the repository at this point in the history

  13. Add files via upload

    @alan8325 @cdecker
    alan8325 authored and cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    4a1bc0f View commit details
    Browse the repository at this point in the history

  14. ping: complete JSON RPC ping commands even if one ping gets no response. 

    We would never complete further ping commands if we had < responses
than pings.  Oops.

Fixes: #1928
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    704d30e View commit details
    Browse the repository at this point in the history

  15. wallet: fix Makefile to include correct dependencies. 

    It didn't depend on its own headers, it should also depend on
lightningd/lightningd.h.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    c2e56fb View commit details
    Browse the repository at this point in the history

  16. wallet: include Makefile from lightningd/Makefile so that lightning h… 

    …eaders defined.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    30f1292 View commit details
    Browse the repository at this point in the history

  17. lightningd: fix Makefile to remove cruft. 

    Everything depends on common headers etc, and the HSM_CLIENT_HEADERS was removed
quite a while ago.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    bcbcf2f View commit details
    Browse the repository at this point in the history

  18. add "io" to -log-level usage

    @arowser @cdecker
    arowser authored and cdecker committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    3372228 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2018

  1. pytest: Fix lint error

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    f505a94 View commit details
    Browse the repository at this point in the history

  2. docker: Prepare builder to include flask and cherrypy 

    This is in preparation for the next commit.
    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    0a5c45e View commit details
    Browse the repository at this point in the history

  3. pytest: Add an RPC proxy inbetween bitcoind and bitcoin-cli 

    This is a simple reverse proxy that `bitcoin-cli` can talk to when invoked by
`lightningd`. It allows us to trace `bitcoin-cli` calls, and intercept calls to
mock the replies, better than the current bash-script based method.
    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    e132dff View commit details
    Browse the repository at this point in the history

  4. pytest: Implement method mocking for ProxiedBitcoinRpc

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    8818602 View commit details
    Browse the repository at this point in the history

  5. btcproxy: Unpack batched JSON-RPC calls and issue them separately

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    74f228d View commit details
    Browse the repository at this point in the history

  6. pytest: Set correct header in mock bitcoind

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    2dabc5a View commit details
    Browse the repository at this point in the history

  7. pytest: Remove auto-proxying in favor of a per-node btc proxy

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    aa80a33 View commit details
    Browse the repository at this point in the history

  8. pytest: Use the bitcoind proxy to mock feerates

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    16869e3 View commit details
    Browse the repository at this point in the history

  9. pytest: Use the mock bitcoind everywhere

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    9e5d7da View commit details
    Browse the repository at this point in the history

  10. pytest: Clean up bitcoind_cmd_override, it's no longer used

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    f29f92a View commit details
    Browse the repository at this point in the history

  11. pytest: Disable early abort if we run in parallel

    @cdecker
    cdecker committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    36eab5d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. CHANGELOG.md: add Unreleased section at the top. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    5f059ef View commit details
    Browse the repository at this point in the history

  2. listpeers: add 'scratch_txid' for the tx we would broadcast if necess… 

    …ary.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    7744c41 View commit details
    Browse the repository at this point in the history

  3. pytest: don't wait for sendrawtx, wait for expected tx. 

    In particular, test_no_fee_estimate was flaky due to seeing the funding
tx being sent.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    252bbe1 View commit details
    Browse the repository at this point in the history

  4. lightningd: make some bitcoind requests high priority. 

        fiatjaf has a cheap VPS, connecting remotely to his home bitcoind node.
    fiatjaf's latency on bitcoin-cli getblock is between 10 and 37 seconds.
    fiatjaf's c-lightning node is getting one block per hour.
    fiatjaf is sad.

We single-file our bitcoind requests, because bitcoind has a limited
thread pool and it *fails* rather than queueing if you upset it.  We
probably be fine using separate queues for each command type, but simply
allowing some requests to cut in line should prove my theory that we're
getting stuck behind gossip verification requests.

    fiatjaf now gets one block per 2 minutes.
    fiatjaf is less sad.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    2cdc5fb View commit details
    Browse the repository at this point in the history

  5. lightningd: make bcli_args() helper take ctx. 

    Otherwise we can get leak complaints: all callers now use tmpctx.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    9b8c8f6 View commit details
    Browse the repository at this point in the history

  6. lightningd: verbose debugging for bitcoind commands. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    e7a0ffc View commit details
    Browse the repository at this point in the history

  7. lightningd: allow more than one bitcoind request at once, run multipl… 

    …e queues.

With the previous patch, we could still get stuck behind a low-prio
request.  Generalize it into separate queues, and allow more than one
request in parallel.

Worth noting that the test time for `VALGRIND=0 pytest -vx tests/ -n 10`
doesn't change measurably.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    f6fb120 View commit details
    Browse the repository at this point in the history