Skip to content
This repository has been archived by the owner on Feb 5, 2022. It is now read-only.

Battery radial around center #71

Closed
wants to merge 2 commits into from
Closed

Battery radial around center #71

wants to merge 2 commits into from

Conversation

dmorgan81
Copy link

Show the remaining battery percentage as a radial around the center.
Battery radial color defaults to GColorIslamicGreen.

Show the remaining battery percentage as a radial around the center.
Battery radial color defaults to GColorIslamicGreen.
@groyoh
Copy link
Collaborator

groyoh commented Apr 13, 2016

Thanks a lot for your PR! We discussed your implementation and we don't think the design blends well with Minimalin, but your code seems good and we're confident we can use part of it for implementing a (redesigned) battery feature.

Next time it would be better to create an issue first in order to provide a design, discuss and iterate on it. I agree it's mostly my fault for not having a contributing guide but I didn't expect people to be so enthusiast about Minimalin.

At the moment, we are focusing on the highest and mediuem priority features. If you would like to work on different feature, please have a look at #69.

@dmorgan81
Copy link
Author

No problem. Thanks for taking a look.

On Wed, Apr 13, 2016 at 2:13 PM Yohan Robert notifications@github.com
wrote:

Thanks a lot for your PR! We discussed your implementation and we don't
think the design blends well with Minimalin, but your code seems good and
we're confident we can use part of it for implementing a (redesigned)
battery feature.

Next time it would be better to create an issue first in order to provide
a design, discuss and iterate on it. I agree it's mostly my fault for not
having a contributing guide but I didn't expect people to be so enthusiast
about Minimalin.

At the moment, we are focusing on the highest and mediuem priority
features. If you would like to work on different feature, please have a
look at #69 #69.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#71 (comment)

@groyoh groyoh closed this Apr 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants