Update unittest frameworks #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
havogt
commented
Jun 16, 2022
havogt
commented
- remove googletest from repo (use FetchContent) and update to version 1.11.
- update pFUnit dependency to 4.4.1 (preparation for testing nvhpc)
|
launch jenkins |
jonasjucker
approved these changes
Jun 20, 2022
| @@ -189,7 +189,7 @@ fi | |||
| # pFUnit | |||
| if [ ! -z ${PFUNIT_INSTALL_DIR+x} ]; then | |||
| SERIALBOX_TESTING_FORTRAN=ON | |||
| SET_PFUNIT_PATH="-DpFUnit_DIR=${PFUNIT_INSTALL_DIR}" | |||
There was a problem hiding this comment.
A question:
To pass PFUNIT to CMAKE I now need to pass its install-dir through "DCMAKE_PREFIX_PATH"?
There was a problem hiding this comment.
Yes, either that or -DPFUNIT_DIR=<path to the directory with PFUNIT.cmake file> (or some other path, as described here https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-search-procedure).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.