-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to FortranWrapper.h that enables SerialBox to compile with Fortran features on MacOS #251
Conversation
…n features on macOS.
Hi there, this is jenkins continuous integration... |
Yes verify the patch |
launch jenkins |
Thanks, for the contribution. Please merge with the updated master to reflect the fixes in CI. |
Additionally, please add yourself at the bottom of the |
And in case your are motivated, a PR to extending the GitHub action tests to MacOS is very welcome, see #246. |
Hi @gmao-ckung, |
Hi @havogt, I apologize for the confusion about my affiliation. Given that this fix is relatively small, I think it’ll be easiest if I take my name off the “AUTHORS” list. I’ll resubmit a version with my name off the list. You can merge the changes once I make the edit. |
Please give Andrea his |
Good catch! |
Thanks again for the fix! |
Compiling the current master branch on MacOS Catalina results in the following undefined symbol errors
The fix is to change the
long
andlong*
parameter types for theInt64
routines inFortranWrapper.h
toint64_t
andint64_t*
respectively.This was tested using MacOS Catalina v 10.15.7 and built using MacOS clang-based C and C++ compilers and gfortran v 11.1.0 installed via Homebrew.