Functional: Compiled backends integration unstructured #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
force-pushed
the
compiled-backends-integration-unstructured3
branch
from
bf3636a
to
82b5c26
Compare
|
Can you try enable the tests in test_toy_connectivity and potentially others |
|
As discussed offline the iterator tests will be enabled in a seperate PR after #1130 is merged. Until then only one test was enabled. |
havogt
requested changes
Jan 25, 2023
| if isinstance(connectivity, Connectivity): | ||
| parameters.append( | ||
| interface.ConnectivityParameter( | ||
| "__conn_" + name.lower(), connectivity.origin_axis.value, name |
There was a problem hiding this comment.
Suggested change
| "__conn_" + name.lower(), connectivity.origin_axis.value, name | |
| "conn_" + name.lower(), connectivity.origin_axis.value, name |
__something is reserved in c++
src/functional/program_processors/codegens/gtfn/itir_to_gtfn_ir.py
Outdated
Show resolved
Hide resolved
src/functional/program_processors/codegens/gtfn/itir_to_gtfn_ir.py
Outdated
Show resolved
Hide resolved
havogt
requested changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for using unstructured backends directly from Python.