Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version switch for GridTools C++ #858

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Remove version switch for GridTools C++ #858

merged 4 commits into from
Aug 2, 2022

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Jul 12, 2022

... since we only use GridTools v2.x now.

@havogt
Copy link
Contributor Author

havogt commented Jul 12, 2022

bors try

bors bot added a commit that referenced this pull request Jul 12, 2022
@bors
Try #858:
46697fd
@havogt havogt requested a review from gronerl July 12, 2022 13:18
@bors
Copy link

bors bot commented Jul 13, 2022

try

Timed out.

@havogt
Copy link
Contributor Author

havogt commented Jul 13, 2022

bors try

@bors
Copy link

bors bot commented Jul 13, 2022

try

Already running a review

@havogt
Copy link
Contributor Author

havogt commented Jul 13, 2022

bors try-

@havogt
Copy link
Contributor Author

havogt commented Jul 13, 2022

bors try

bors bot added a commit that referenced this pull request Jul 13, 2022
@bors
Try #858:
697d562
gronerl
gronerl requested changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@gronerl gronerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md needs an update as well.

@bors
Copy link

bors bot commented Jul 13, 2022

try

Build failed:

@gronerl
Copy link
Contributor

gronerl commented Jul 13, 2022

Daint has issues today.

@jdahm
Copy link
Contributor

jdahm commented Jul 20, 2022

I like this. I wonder: could we simply remove the gt_src_manager altogether and use a submodule?

@havogt
Copy link
Contributor Author

havogt commented Jul 20, 2022

We are considering shipping GridTools via pip for functional, see GridTools/gridtools#1720

@havogt
Copy link
Contributor Author

havogt commented Jul 21, 2022

bors try

bors bot added a commit that referenced this pull request Jul 21, 2022
@bors
Try #858:
bc05d6b
@bors
Copy link

bors bot commented Jul 21, 2022

try

Timed out.

@jdahm
Copy link
Contributor

jdahm commented Aug 1, 2022

bors try

bors bot added a commit that referenced this pull request Aug 1, 2022
@bors
Try #858:
77a447c
@bors
Copy link

bors bot commented Aug 1, 2022

try

Build succeeded:

@jdahm jdahm requested a review from gronerl August 1, 2022 20:27
@jdahm
Copy link
Contributor

jdahm commented Aug 1, 2022

@gronerl Can you re-review?

@gronerl
Copy link
Contributor

gronerl commented Aug 2, 2022

bors try

bors bot added a commit that referenced this pull request Aug 2, 2022
@bors
Try #858:
8e0e741
@bors
Copy link

bors bot commented Aug 2, 2022

try

Build succeeded:

@gronerl gronerl merged commit 7bfa7ea into master Aug 2, 2022
gronerl pushed a commit to gronerl/gt4py that referenced this pull request Aug 4, 2022
@havogt @jdahm
Remove version switch for GridTools C++ (GridTools#858)
4dbada1 
Remove version switch for GridTools C++ since we only use GridTools v2.x now.

Co-authored-by: Johann Dahm <johann.dahm@gmail.com>
@havogt havogt deleted the remove_gtversion_switch branch December 19, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gronerl gronerl gronerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@havogt @gronerl @jdahm