feat[next]: itir.embedded support for Lists in output #1703
+298
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
commented
Oct 23, 2024
| @@ -116,7 +116,31 @@ def visit_FieldOperator( | |||
| def visit_ScanOperator( | |||
| self, node: foast.ScanOperator, **kwargs: Any | |||
| ) -> itir.FunctionDefinition: | |||
| raise NotImplementedError("TODO") | |||
| # note: we don't need the axis here as this is handled by the program | |||
havogt
commented
Oct 23, 2024
| @@ -920,9 +936,9 @@ def deref(self) -> Any: | |||
| return _make_tuple(self.field, position, column_axis=self.column_axis) | |||
|
|
|||
|
|
|||
| def _get_sparse_dimensions(axes: Sequence[common.Dimension]) -> list[Tag]: | |||
| def _get_sparse_dimensions(axes: Sequence[common.Dimension]) -> list[common.Dimension]: | |||
havogt
commented
Oct 24, 2024
|
ready for a first round of review |
tehrengruber
approved these changes
Oct 28, 2024
| @@ -0,0 +1,95 @@ | |||
| # GT4Py - GridTools Framework | |||
There was a problem hiding this comment.
Maybe a skipped test for the case we don't support yet makes sense: if(..., const_list_val, list_val)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lists returned from an
as_fieldoped stencil will be turned into a local dimension of the the resulting field.In case of a
make_const_list, a magic local dimension_CONST_DIMis used. This is a hack, but localized toitir.embedded. A clean implementation will probably involve to tag themake_const_listwith the neighborhood it is meant to be used with.