Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[next]: make past_to_itir cached in default transforms #1555

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Jun 13, 2024

Description

Make the default transforms use

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • All the authors are covered by a valid contributor assignment agreement provided to ETH Zurich and signed by the employer if needed.
  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

@DropD DropD marked this pull request as ready for review June 13, 2024 08:28
@DropD DropD requested a review from tehrengruber June 13, 2024 08:29
Copy link
Contributor

@tehrengruber tehrengruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed the superficial nesting in PastToITIR is terrible, but I can live with that for now. Please add a small todo then we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants