-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[next]: workflowify PAST -> ITIR toolchain step #1479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple of things that I would move around and I'd split the past_to_func into a separate PR.
… into c20_workflowefy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first step! You need to merge with main to get CI green.
Maybe update the title before merge to be a bit more specific as it's only part of the workflowify |
## New: - "next.ffront": - ".past_to_itir": workflow step PAST -> ITIR - ".transform_utils": some utility functions moved from "next.ffront.decorator" ## Changed: - "Backend": - is not a "ProgramProcessor" anymore - still passes "is_program_backend" test - new attribute ".transformer", a workflow which prepares for the ".executor" - currently starts at "stages.PastClosure" (PAST node + args, kwargs) but will evolve into starting from function definition + args, kwargs - "ModularExecutor": - is now a "ProgramExecutor" (passes "is_processor_kind" test) - "program_processor_interface": - "is_program_backend" test now checks for existence of an ".executor" attribute, which must pass the executor test - "ffront.decorator": - several utilities and methods refactored out into the new modules - tests: test utils / fixtures refactored to deal with backends which are not executors --------- Co-authored-by: nfarabullini <nicoletta.farabullini@c2sm.ethz.ch> Co-authored-by: Rico Häuselmann <ricoh@cscs.ch>
New:
Changed:
"Backend":
"ModularExecutor":
"program_processor_interface":
"ffront.decorator":
tests: test utils / fixtures refactored to deal with backends which are not executors