Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor[next]: Typing for bindings #1218

Merged
merged 5 commits into from
Mar 27, 2023
Merged

refactor[next]: Typing for bindings #1218

merged 5 commits into from
Mar 27, 2023

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Mar 23, 2023

Extracted from #1130 and married with Connectivities.

@havogt havogt mentioned this pull request Mar 24, 2023
Merged
egparedes
egparedes reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, just minor suggestions

src/gt4py/next/otf/binding/cpp_interface.py Outdated Show resolved Hide resolved
src/gt4py/next/otf/binding/pybind.py Outdated Show resolved Hide resolved
tests/next_tests/otf_tests/conftest.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/codegens/gtfn/gtfn_module.py Outdated Show resolved Hide resolved
havogt and others added 2 commits March 24, 2023 13:22
@havogt @egparedes
Update src/gt4py/next/otf/binding/cpp_interface.py
237c91e 
Co-authored-by: Enrique G. Paredes <18477+egparedes@users.noreply.github.com>
@havogt
address review comments
7df905d
@havogt havogt requested a review from egparedes March 24, 2023 12:35
@havogt
Copy link
Contributor Author

havogt commented Mar 24, 2023

tests failing because #1222

egparedes
egparedes approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. It could be merged now if it is urgent, since the test error is unrelated to this PR and it will be fixed in #1222

@havogt
Copy link
Contributor Author

havogt commented Mar 27, 2023

cscs-ci not available this week, merging...

@havogt havogt merged commit 9b9652a into GridTools:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

@petiaccja petiaccja Awaiting requested review from petiaccja

@tehrengruber tehrengruber Awaiting requested review from tehrengruber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havogt @egparedes