-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Const to SID Neighbor Table Element Type #1808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed address space" because of __ldg on array
…st and avoid reading fields that are independent of the vertical level in each iteration
Improvements in `sid` handling as `const` in `as_neighbor_table` Co-authored-by: Felix Thaler <felix.thaler@nummi.ch>
Hi there, this is jenkins continuous integration... |
launch perftest |
launch jenkins |
launch jenkins |
launch perftest |
launch jenkins |
launch jenkins |
launch perftest |
iomaganaris
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking care of this and adding a test 👍
havogt
pushed a commit
that referenced
this pull request
Oct 30, 2024
Allows NVCC to use `LDG` instructions and thus perform better double-load elision. Credit goes to @iomaganaris. Further, fixes `sid::as_const` for C arrays. --------- Co-authored-by: Ioannis Magkanaris <ioannis.magkanaris@cscs.ch>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows NVCC to use
LDG
instructions and thus perform better double-load elision. Credit goes to @iomaganaris. Further, fixessid::as_const
for C arrays.