Fixes for HIP detection for recent ROCm and CMake #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch jenkins |
|
launch jenkins |
fthaler
requested changes
Sep 25, 2024
Co-authored-by: Felix Thaler <felix.thaler@nummi.ch>
|
launch jenkins |
fthaler
approved these changes
Sep 25, 2024
|
launch jenkins |
havogt
added a commit
that referenced
this pull request
Sep 30, 2024
- New minimum CMake version requirement 3.21.0 for HIP language support - Hip detection via `check_language` instead of compiler binary name - Enable workarounds for Clang 17 (which where already needed for Clang 16 and earlier) - Fix for deprecated `ptrAttributes.memoryType` (was already changed in CUDA since a while) - Add cuda error checks for functions that return an error with `[[no_discard]]` in hip. --------- Co-authored-by: Felix Thaler <felix.thaler@nummi.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_languageinstead of compiler binary nameptrAttributes.memoryType(was already changed in CUDA since a while)[[no_discard]]in hip.