Use __ldg on Scalar Read-only Data Stores #1795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch perftest |
|
Hi there, this is jenkins continuous integration... |
|
launch jenkins |
|
launch perftest |
|
launch jenkins |
havogt
requested changes
Aug 2, 2024
| @@ -23,6 +23,10 @@ | |||
| #include "../meta.hpp" | |||
| #include "data_store.hpp" | |||
|
|
|||
| #if defined(__CUDA_ARCH__) && __CUDA_ARCH__ >= 350 | |||
There was a problem hiding this comment.
see both comments in the other __ldg pr
| @@ -32,11 +36,43 @@ namespace gridtools { | |||
| return lhs; | |||
| } | |||
| }; | |||
| template <class T> | |||
| struct const_ptr_wrapper { | |||
There was a problem hiding this comment.
Should that better live somewhere in the sid module and possibly become the default also for simple_ptr_holder?
|
Closed in favor of #1802 |
fthaler
added a commit
that referenced
this pull request
Sep 24, 2024
Additionally fixes missing `host_view` etc. in const data stores. Gives speedups when combined with #1795.
havogt
pushed a commit
that referenced
this pull request
Sep 30, 2024
Additionally fixes missing `host_view` etc. in const data stores. Gives speedups when combined with #1795.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
__ldginstruction on loads from read-only data stores with supported scalar data types. This might improve performance due to more optimal caching and helps NVCC to elide redundant load instructions.