Update nanobind to v2 #1777
Merged
Update nanobind to v2 #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch jenkins |
|
Because of this change wjakob/nanobind#377 our test setup is now broken. We have to run a test from Python. |
|
launch jenkins |
|
launch jenkins |
fthaler
requested changes
Jun 5, 2024
| template <std::size_t... Values> | ||
| using stride_spec = std::index_sequence<Values...>; | ||
| // Use `-1` for dynamic stride, use an integral value for static stride. | ||
| template <ssize_t... Values> |
There was a problem hiding this comment.
I think we use int for indices internally at quite a few places in GridTools, so maybe this would also be good enough here (this might even have a performance impact).
There was a problem hiding this comment.
I actually used the wrong ssize_t. It's actually a nb type defined here https://github.com/wjakob/nanobind/blob/c5ae2a36a704c1c62da99a81fad919261a3e9848/include/nanobind/nb_traits.h#L11.
I'll use that. We could still convert (runtime) strides to int, but I would do separately and probably should look at performance.
fthaler
approved these changes
Jun 12, 2024
|
launch jenkins |
|
launch jenkins |
havogt
added a commit
that referenced
this pull request
Jun 18, 2024
- nb::any is replaced by `nb::ssize_t(-1)` - Because of a change in `~ndarray`, we need to make sure that Python is initialized in our tests (see wjakob/nanobind#377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssize_t(-1)~ndarray, we need to make sure that Python is initialized in our tests (see [BUG]:nb::ndarrayarguments withnb::call_guard<nb::gil_scoped_release>on Python 3.12 wjakob/nanobind#377)