Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python packaging #1720
Support Python packaging #1720
Changes from all commits
03b7de3
2e13579
43a1b10
51b7fd4
f81f6bb
6c3f99b
be6f794
37f68ff
6d00ba2
06333b8
2cea7bf
e37f977
7662b29
41fa89a
5fe6a99
35ef68f
c4bb261
8a9a674
e2f1047
0628d7f
2e1b28e
ccaf5f8
8e8be70
d2289e9
c77d8ee
23cc4eb
1085e5b
c6155bf
7ddd678
6e2fec7
e04a3b4
d17034e
393649a
006c084
1483de8
01eab36
2a96235
be0095f
5ac7494
72c54b7
863c647
eb9f344
353dc1d
38b1596
001b1ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably you're already aware, but
configparser
removes all comments and formatting from the original file. It's not very important in this case, though, but it is not nice. The only alternative I know which preserves format is ConfigUpdate (https://pypi.org/project/ConfigUpdater/) but is a third-party projectThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment, maybe it would be good to add all packages used or installed here (
build
,cmake
, ...) to the list ofbuild_system.requires
in pyproject.toml to make the dependencies explicit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add them for documentation purposes, even they are not build requirements anymore. They are pre-build requirements. In the PEP-517 conformant isolated build environment, they don't have to be present.
A compromise might be to add them commented-out, I guess?