Sketch of Python neighbor table #1719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
commented
Jul 13, 2022
| @@ -170,5 +170,6 @@ namespace gridtools::fn { | |||
| } // namespace unstructured_impl_ | |||
|
|
|||
| using unstructured_impl_::connectivity; | |||
| using unstructured_impl_::make_backend; | |||
There was a problem hiding this comment.
TODO try undo, probably not needed after I fixed my GT4Py code
havogt
commented
Jul 13, 2022
Comment on lines
+26
to
+28
| // The module exports several instantiations of the generic `copy` to python. | ||
| // The differences between exported functions are in the way how parameters model the SID concept. | ||
| // Note that the generic algorithm stays the same. |
There was a problem hiding this comment.
Suggested change
| // The module exports several instantiations of the generic `copy` to python. | |
| // The differences between exported functions are in the way how parameters model the SID concept. | |
| // Note that the generic algorithm stays the same. |
havogt
commented
Jul 13, 2022
Comment on lines
+11
to
+17
| print(tbl.shape) | ||
| print(testee.get_neighbor_0(tbl, 0)) | ||
| print(testee.get_neighbor_1(tbl, 0)) | ||
| print(testee.get_neighbor_2(tbl, 0)) | ||
| print(testee.get_neighbor_0(tbl, 1)) | ||
| print(testee.get_neighbor_1(tbl, 1)) | ||
| print(testee.get_neighbor_2(tbl, 1)) |
havogt
commented
Jul 21, 2022
| @@ -26,7 +26,13 @@ if(NOT pybind11_POPULATED) | |||
| endif() | |||
|
|
|||
| pybind11_add_module(py_implementation implementation.cpp) | |||
| target_compile_options(py_implementation PUBLIC $<$<COMPILE_LANGUAGE:CXX>:-std=c++17>) | |||
|
Closing in favor of #1730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it makes sense to add it to this repo or if we should keep it on the GT4Py side...