workaround an nvcc bug #1681
Merged
workaround an nvcc bug #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
approved these changes
Dec 9, 2021
| @@ -369,7 +369,7 @@ namespace gridtools { | |||
| template <class Fun> | |||
| struct get_fun_result { | |||
| template <class... Ts> | |||
| using apply = decltype(std::declval<Fun const &>()(std::declval<Ts>()...)); | |||
| using apply = decltype(std::declval<std::add_lvalue_reference_t<std::add_const_t<Fun>>>()(std::declval<Ts>()...)); | |||
There was a problem hiding this comment.
I mean is there any difference between the old and the new version?
|
launch jenkins |
|
No difference. Just to avoid nvcc warning
…On Thu, 9 Dec 2021 at 17:40, Hannes Vogt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In include/gridtools/common/tuple_util.hpp
<#1681 (comment)>:
> @@ -369,7 +369,7 @@ namespace gridtools {
template <class Fun>
struct get_fun_result {
template <class... Ts>
- using apply = decltype(std::declval<Fun const &>()(std::declval<Ts>()...));
+ using apply = decltype(std::declval<std::add_lvalue_reference_t<std::add_const_t<Fun>>>()(std::declval<Ts>()...));
I mean is there any difference between the old and the new version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1681 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHQT63XYM6JBLALWIHQNP4DUQDLZNANCNFSM5JWLSPRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
havogt
pushed a commit
to havogt/gridtools
that referenced
this pull request
Apr 6, 2023
Fix a problem where nvcc doesn't distinguish type and non-type template parameters of template template parameters. See https://godbolt.org/z/orrev1xnM
havogt
pushed a commit
to havogt/gridtools
that referenced
this pull request
Apr 11, 2023
Fix a problem where nvcc doesn't distinguish type and non-type template parameters of template template parameters. See https://godbolt.org/z/orrev1xnM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.