Fix performance with C++17 #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I propose we should also port this back to |
anstaf
approved these changes
Mar 11, 2021
|
launch jenkins |
|
launch jenkins |
|
tests on daint are ok |
havogt
pushed a commit
to havogt/gridtools
that referenced
this pull request
Mar 23, 2021
With C++17, `as_const` was added into the standard and if `as_const` is not called qualified, we end up with `std::as_const` (which is also a better match) in most cases because there is some `std` inside one of the template arguments. By qualifying `as_const`, performance is fixed. For GTBench, performance is identical with `-std=c++14` and `-std=c++17` now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With C++17,
as_constwas added into the standard and ifas_constis not called qualified, we end up withstd::as_const(which is also a better match) in most cases because there is somestdinside one of the template arguments.By qualifying
as_const, performance is fixed.For GTBench, performance is identical with
-std=c++14and-std=c++17now.