Fix modulo in GCL #1355
Merged
Fix modulo in GCL #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch strgrid |
havogt
reviewed
Sep 2, 2019
| @@ -181,23 +181,23 @@ namespace gridtools { | |||
| int _coords[3]; | |||
|
|
|||
| if (m_cyclic.value(0)) | |||
There was a problem hiding this comment.
Whether it should be a cyclic communicator. If the communicator is not cyclic, we don't need to communicate; so we don't need the fix in the else case.
|
We need the backport. We can do it once this is reviewed. |
|
launch mpistrgrid |
mbianco
approved these changes
Oct 7, 2019
havogt
pushed a commit
that referenced
this pull request
Oct 7, 2019
If `m_coordines[x] == 0` and `X == -1`, we might do `-1 % N`. The sign of the result was implementation-defined pre-stdc++11; in GCC 7.3 this is incorrectly still negative, which leads to problems with MPI later in the code. Backport of #1355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
m_coordines[x] == 0andX == -1, we might do-1 % N. The sign of the result was implementation-defined pre-stdc++11; in GCC 7.3 this is incorrectly still negative, which leads to problems with MPI later in the code.(Maybe), backport to gridtools 1.0 required.