Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to C++14 #1307

Merged
merged 35 commits into from
May 24, 2019
Merged

Move to C++14 #1307

merged 35 commits into from
May 24, 2019

Conversation

lukasm91
Copy link
Contributor

@lukasm91 lukasm91 commented May 20, 2019 •
edited
Loading

  • Remove GT_META_CALL, GT_META_DEFINE_ALIAS and GT_META_LAZY_NAMESPACE
  • Remove GT_BROKEN_TEMPLATE_ALIASES
  • Remove CUDA 8 workarounds / CMake support / documentation
  • Remove C++11 support
  • Replace *_t type traits with std::*_t

Disabled unittests test_export and test_generator, and the c-bindings example for CUDA < 10.0 (i.e., CUDA 9.1 and CUDA 9.2) in combination with clang as host compiler because of problems with operator ""if (the only workaround would be to replace boost::type_index)

TODO (next PR): Remove integer_sequence and friends

@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch icgrid

@lukasm91 lukasm91 changed the title Remove gt meta call [WIP] Remove gt meta call May 22, 2019
@anstaf
Copy link
Contributor

anstaf commented May 23, 2019

The

@anstaf anstaf closed this May 23, 2019
@anstaf anstaf reopened this May 23, 2019
@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch icgrid

@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch icgrid

anstaf
anstaf requested changes May 23, 2019
View reviewed changes
tools/clang_format/clang_format_all.sh Outdated Show resolved Hide resolved
@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch icgrid

@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch icgrid

@lukasm91
Copy link
Contributor Author

From my side, this PR is ready to be merged. I will remove std::integer_sequence and friends in a new PR.

@lukasm91 lukasm91 requested a review from anstaf May 24, 2019 05:33
@lukasm91 lukasm91 mentioned this pull request May 24, 2019
Merged
@lukasm91
Copy link
Contributor Author

do perftest

@anstaf anstaf merged commit 00ba53c into GridTools:master May 24, 2019
@lukasm91 lukasm91 deleted the remove_gt_meta_call branch May 27, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anstaf anstaf anstaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasm91 @anstaf