-
Notifications
You must be signed in to change notification settings - Fork 23
Add Ubuntu build automation via PNNL GitLab #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- Split the script into two (one for installing dependencies and other for GridPACK) - Ignore boost includes and boost libraries in GridPACK.cmake.in. Otherwise python installation fails. - Update GridPACK installation script with addition CMake flags for Boost.
- Remove directory changes and assume current directory - Use local variables in functions - Capture logs
Missing bash causes issues sourcing lib script
The Rocky Linux jobs in |
This looks like the Python development package ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but, the two scripts that were deleted still need to function outside of the container environment. These were sort of generic before. It would be good to retain that and still work on an OS other than the containers used (Debian, e.g).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that this script no longer stands alone. Somewhere in the documentation, new users were directed to use this script to install GridPACK dependencies. Does it work outside of the container environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been tested outside of the container environment?
install_package_deps_lib.sh
to install packages to each container image based on the detected distribution.install_gridpack.sh
.install_from_source_deps.sh
(wasinstall_gridpack_deps.sh
) and breaks out pieces intoinstall_boost.sh
,install_ga.sh
, andinstall_petsc.sh
..gitlab-ci.yml
. this contains 1) jobs to test if the container image needs rebuilt, 2) a job to build a container image used as the environment for subsequent jobs, 3) a job that installs gridpack, and 4) a job that runs the tests for that gridpack installation.dockerfile
which is the definition for the container image to be built. besides setting environment variables, this usesinstall_boost.sh
,install_ga.sh
,install_petsc.sh
, andinstall_gridpack_deps.sh
.