Skip to content

Add Ubuntu build automation via PNNL GitLab #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 197 commits into
base: develop
Choose a base branch
from

Conversation

jacksavage
Copy link

@jacksavage jacksavage commented Jan 24, 2024

  • adds install_package_deps_lib.sh to install packages to each container image based on the detected distribution.
  • updates install_gridpack.sh.
  • updates install_from_source_deps.sh (was install_gridpack_deps.sh) and breaks out pieces into install_boost.sh, install_ga.sh, and install_petsc.sh.
  • adds definition for a gitlab build pipeline via .gitlab-ci.yml. this contains 1) jobs to test if the container image needs rebuilt, 2) a job to build a container image used as the environment for subsequent jobs, 3) a job that installs gridpack, and 4) a job that runs the tests for that gridpack installation.
  • adds dockerfile which is the definition for the container image to be built. besides setting environment variables, this uses install_boost.sh, install_ga.sh, install_petsc.sh, and install_gridpack_deps.sh.
  • split off of Add Rocky build automation via PNNL GitLab #173 to get the ubuntu build incorporated while troubleshooting continues on the rocky linux build

abhyshr and others added 30 commits August 28, 2023 11:22
- Split the script into two (one for installing dependencies and other for GridPACK)
- Ignore boost includes and boost libraries in GridPACK.cmake.in. Otherwise python
  installation fails.
- Update GridPACK installation script with addition CMake flags for Boost.
- Remove directory changes and assume current directory
- Use local variables in functions
- Capture logs
@jacksavage
Copy link
Author

The Rocky Linux jobs in /.gitlab-ci.yml have been virtually disabled using when: manual. This means they will only be run if someone clicks a button from the pipeline view in the GitLab UI. As the support for Rocky Linux build automation stands, an error is encountered when trying to install GridPACK to the container environment after running /usr/bin/python3 setup.py build. This can be seen in job #165811 on GitLab.

image

@jacksavage
Copy link
Author

@wperkins and @abhyshr, I think this is ready to merge and includes a decent number of changes since last review. Could you please give it another look when you have a moment?

@wperkins
Copy link
Member

wperkins commented Feb 27, 2024

The Rocky Linux jobs in /.gitlab-ci.yml have been virtually disabled using when: manual. This means they will only be run if someone clicks a button from the pipeline view in the GitLab UI. As the support for Rocky Linux build automation stands, an error is encountered when trying to install GridPACK to the container environment after running /usr/bin/python3 setup.py build. This can be seen in job #165811 on GitLab.

[...]

This looks like the Python development package (python3.11-devel, maybe) was not installed.

Copy link
Member

@wperkins wperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but, the two scripts that were deleted still need to function outside of the container environment. These were sort of generic before. It would be good to retain that and still work on an OS other than the containers used (Debian, e.g).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that this script no longer stands alone. Somewhere in the documentation, new users were directed to use this script to install GridPACK dependencies. Does it work outside of the container environment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested outside of the container environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants