-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove opentsdb addr #203
Conversation
@daviderli614 After the PR is merged, we need to release the new version. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #203 +/- ##
===========================================
+ Coverage 40.96% 41.01% +0.04%
===========================================
Files 16 16
Lines 991 990 -1
===========================================
Hits 406 406
+ Misses 480 479 -1
Partials 105 105 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first PR in Greptime🎉
chore: remove opentsdb addr (GreptimeTeam#203)
In the new version, OpentsdbAddr is not used.
So,I delete the OpentsdbAddr in order to run gtctl correctly