Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get support for bare-metal #137

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 24, 2023

effects:

~ ./bin/gtctl cluster get test --bare-metal

+-----------+-----------+
| COMPONENT |    PID    |
+-----------+-----------+
| frontend  | .0: 82062 |
+-----------+-----------+
| datanode  | .0: 82059 |
+           +-----------+
|           | .1: 82060 |
+           +-----------+
|           | .2: 82061 |
+-----------+-----------+
| metasrv   |     82058 |
+-----------+-----------+
| etcd      |     82054 |
+-----------+-----------+
CREATION-DATE: 2023-08-23 23:11:57.432645 +0800 CST
GREPTIMEDB-VERSION: latest
ETCD-VERSION: v3.5.7
CLUSTER-DIR: /.gtctl/test
CLUSTER-CONFIG:
cluster:
    artifact:
        local: ""
        version: latest
    frontend:
        replicas: 1
        grpcAddr: ""
        httpAddr: ""
        postgresAddr: ""
        metaAddr: ""
        logLevel: ""
    meta:
        storeAddr: 127.0.0.1:2379
        serverAddr: 0.0.0.0:3002
        bindAddr: ""
        httpAddr: 0.0.0.0:14001
        logLevel: ""
    datanode:
        replicas: 3
        nodeID: 0
        rpcAddr: 0.0.0.0:14100
        httpAddr: 0.0.0.0:14300
        dataDir: ""
        walDir: ""
        procedureDir: ""
        logLevel: ""
etcd:
    artifact:
        local: ""
        version: v3.5.7

after the implementation of get, the list, connect, update cmd can be implemented.

related to #96

Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from zyy17 August 24, 2023 02:39
Signed-off-by: sh2 <shawnhxh@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Merging #137 (9fa3fcc) into develop (2f00e10) will decrease coverage by 1.98%.
The diff coverage is 27.91%.

@@             Coverage Diff             @@
##           develop     #137      +/-   ##
===========================================
- Coverage    29.38%   27.40%   -1.98%     
===========================================
  Files            8        9       +1     
  Lines          953     1153     +200     
===========================================
+ Hits           280      316      +36     
- Misses         608      765     +157     
- Partials        65       72       +7     
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/get/get.go 9.92% <12.03%> (ø)
pkg/deployer/baremetal/deployer.go 34.92% <47.19%> (-0.55%) ⬇️

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great!

Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 merged commit df9802b into GreptimeTeam:develop Aug 24, 2023
6 checks passed
@shawnh2 shawnh2 deleted the add-get-for-bm branch August 24, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants