Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bitnamic etcd chart and add charts cache #135

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 23, 2023

What's changed

  1. Support bitnami etcd chart that stores in OCI registry;
  2. Support helm charts cache;
  3. Refactor helm Render and rename to Manager, and simplify the interface(the user only need to call one API LoadAndRenderChart());

Related issues

@zyy17 zyy17 force-pushed the feat/support-etcd-bitnami-chart branch from 6f2baf2 to 320d156 Compare August 23, 2023 11:13
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #135 (1d2da17) into develop (294be69) will increase coverage by 12.44%.
Report is 4 commits behind head on develop.
The diff coverage is 53.67%.

@@             Coverage Diff              @@
##           develop     #135       +/-   ##
============================================
+ Coverage    21.94%   34.38%   +12.44%     
============================================
  Files            8        8               
  Lines          948     1079      +131     
============================================
+ Hits           208      371      +163     
+ Misses         683      621       -62     
- Partials        57       87       +30     
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/helm/helm.go 52.54% <54.47%> (+19.21%) ⬆️

... and 1 file with indirect coverage changes

@shawnh2
Copy link
Contributor

shawnh2 commented Aug 24, 2023

in e2e, it seems has trouble creating the cluster

@zyy17 zyy17 force-pushed the feat/support-etcd-bitnami-chart branch from 2f9cf2c to 047238f Compare August 24, 2023 09:42
@zyy17
Copy link
Collaborator Author

zyy17 commented Aug 24, 2023

@shawnh2 The PDB resources(generated by bitnami etcd chart) that use policy/v1beta1 are removed in K8s v1.25+. I use the fixed kind node image v1.24.15 to fix it.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/helm/constants.go Outdated Show resolved Hide resolved
@zyy17 zyy17 merged commit 17e4e6d into GreptimeTeam:develop Aug 24, 2023
6 checks passed
@zyy17 zyy17 deleted the feat/support-etcd-bitnami-chart branch August 24, 2023 15:49
This was referenced Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants