refactor: replace some usage of MutableBitmap by BitVec #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR replaces some usage of MutableBitmap by
BitVec
:VectorOp::find_unique()
BatchOp::find_unique()
DedupReader
now buffers theBitVec
and resets it before each iteration.As the official arrow doesn't have a mutable bitmap struct, this PR could help reduce some migration work.
Note that the
ListVectorBuilder
still requiresMutableBitmap
.Checklist
Refer to a related PR or issue link (optional)