Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manifest improvements #303

Merged
merged 10 commits into from
Oct 13, 2022
Merged

feat: manifest improvements #303

merged 10 commits into from
Oct 13, 2022

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Oct 10, 2022

Try to fix #281 and #282.

@killme2008 killme2008 marked this pull request as ready for review October 12, 2022 05:17
@killme2008 killme2008 requested review from evenyag and v0y4g3r October 12, 2022 05:21
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #303 (5dcc3ee) into develop (752be8d) will increase coverage by 0.08%.
The diff coverage is 95.16%.

@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
+ Coverage    84.28%   84.36%   +0.08%     
===========================================
  Files          319      319              
  Lines        28954    29128     +174     
===========================================
+ Hits         24403    24573     +170     
- Misses        4551     4555       +4     
Flag Coverage Δ
rust 84.36% <95.16%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/lib.rs 100.00% <ø> (ø)
src/storage/src/region.rs 91.70% <76.66%> (-2.11%) ⬇️
src/storage/src/region/writer.rs 92.90% <96.42%> (+0.68%) ⬆️
src/storage/src/region/tests/alter.rs 98.75% <98.75%> (-0.01%) ⬇️
src/storage/src/manifest/action.rs 91.83% <100.00%> (+0.34%) ⬆️
src/storage/src/manifest/impl_.rs 94.44% <100.00%> (-0.80%) ⬇️
src/storage/src/manifest/region.rs 96.66% <100.00%> (+0.51%) ⬆️
src/storage/src/region/tests.rs 96.49% <100.00%> (+0.26%) ⬆️
src/storage/src/version.rs 91.17% <100.00%> (ø)
src/table-engine/src/manifest.rs 91.48% <100.00%> (-0.35%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@waynexia waynexia self-requested a review October 12, 2022 06:05
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

I also see some changes about ProtocolAction, are they necessary for this patch?

src/storage/src/region.rs Outdated Show resolved Hide resolved
src/table-engine/src/manifest/action.rs Outdated Show resolved Hide resolved
src/storage/src/manifest/action.rs Outdated Show resolved Hide resolved
src/storage/src/region/tests.rs Outdated Show resolved Hide resolved
src/storage/src/region/writer.rs Outdated Show resolved Hide resolved
src/storage/src/region/writer.rs Show resolved Hide resolved
src/storage/src/region/tests/alter.rs Show resolved Hide resolved
@killme2008 killme2008 force-pushed the feature/improve-manifest branch from 9b10d7d to 0718e17 Compare October 12, 2022 09:34
@killme2008
Copy link
Contributor Author

In general LGTM.

I also see some changes about ProtocolAction, are they necessary for this patch?

It's not necessary, but i want to do this refactor for a long time.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 494a93c into develop Oct 13, 2022
@evenyag evenyag deleted the feature/improve-manifest branch October 13, 2022 07:43
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: adds commited_sequence to RegionChange action, GreptimeTeam#281

* refactor: saving protocol action when writer version is changed

* feat: recover all region medata in manifest and replay them when replaying WAL, GreptimeTeam#282

* refactor: minor change and test recovering metadata after altering table schema

* fix: write wrong min_reader_version into manifest for region

* refactor: move up DataRow

* refactor: by CR comments

* test: assert recovered metadata

* refactor: by CR comments

* fix: comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region replay supports schema alteration during replay
3 participants