-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manifest improvements #303
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #303 +/- ##
===========================================
+ Coverage 84.28% 84.36% +0.08%
===========================================
Files 319 319
Lines 28954 29128 +174
===========================================
+ Hits 24403 24573 +170
- Misses 4551 4555 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM.
I also see some changes about ProtocolAction
, are they necessary for this patch?
9b10d7d
to
0718e17
Compare
It's not necessary, but i want to do this refactor for a long time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: adds commited_sequence to RegionChange action, GreptimeTeam#281 * refactor: saving protocol action when writer version is changed * feat: recover all region medata in manifest and replay them when replaying WAL, GreptimeTeam#282 * refactor: minor change and test recovering metadata after altering table schema * fix: write wrong min_reader_version into manifest for region * refactor: move up DataRow * refactor: by CR comments * test: assert recovered metadata * refactor: by CR comments * fix: comment
Try to fix #281 and #282.