feat(promql): add holt_winters initial implementation #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etolbakov
commented
Apr 7, 2023
35 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1342 +/- ##
===========================================
- Coverage 85.96% 85.24% -0.73%
===========================================
Files 506 515 +9
Lines 76892 77825 +933
===========================================
+ Hits 66103 66340 +237
- Misses 10789 11485 +696 |
waynexia
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks for this @etolbakov. Your implementation is very clean and the tests are concrete 🚀
yuanbohan
approved these changes
Apr 11, 2023
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
) * feat(promql): add holt_winters initial implementation * feat(promql): improve docs for holt_winters * feat(promql): adjust holt_winters implementation according to code review * feat(promql): add holt_winters test from prometheus promql function test suite * feat(promql): add holt_winters more tests from prometheus promql function test suite * feat(promql): fix styling issue Co-authored-by: Ruihang Xia <waynestxia@gmail.com> --------- Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement the
holt_wintersfunction (strictly speaking, it is aholt/ Double exponential smoothing since it doesn't use theseasonalityparameter. In order to achieve parity with PromQL we have to follow this naming/implementation).I used this website for implementation validation.
Checklist
Refer to a related PR or issue link
#1307
prometheus/prometheus#2458