-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support table options #1044
Merged
MichaelScofield
merged 5 commits into
GreptimeTeam:develop
from
v0y4g3r:feat/table-ttl-options
Feb 21, 2023
Merged
feat: support table options #1044
MichaelScofield
merged 5 commits into
GreptimeTeam:develop
from
v0y4g3r:feat/table-ttl-options
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90afb4d
to
d6f4a43
Compare
v0y4g3r
commented
Feb 20, 2023
67939cf
to
4650d5a
Compare
2 tasks
4650d5a
to
3d165ab
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1044 +/- ##
===========================================
- Coverage 85.82% 85.72% -0.11%
===========================================
Files 446 446
Lines 64897 65073 +176
===========================================
+ Hits 55698 55781 +83
- Misses 9199 9292 +93
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fengjiachun
approved these changes
Feb 20, 2023
MichaelScofield
approved these changes
Feb 21, 2023
5e7caa5
to
69ddc0d
Compare
69ddc0d
to
0427d64
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: change table options from string map to a struct, add ttl and write_buffer_size * fix: also pass table options to table meta * feat: pass table options when opening/creating regions * fix: CR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Allow user to specify table options when creating table. These options are also persisted to manifest/metasrv.
We can now creating table like:
The table options are persisted to table manifest:
Also in this PR, regions now respect user specified
max_write_buffer_size
when creating table. Table engine will create aSizeBasedStrategy
with that value for each region.Checklist
Refer to a related PR or issue link (optional)