fix(docker): failed to build image on Mac M1 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
approved these changes
Jan 17, 2023
yuanbohan
force-pushed
the
fix-build-image-failur-on-mac-m1
branch
from
056ad26
to
9987d8c
Compare
|
|
|
@ZonaHex PTAL. It seems we don't have remove image optimisations using this. |
yuanbohan
force-pushed
the
fix-build-image-failur-on-mac-m1
branch
from
9987d8c
to
ad489f5
Compare
ZonaHex
reviewed
Jan 18, 2023
Comment on lines
+27
to
32
| docker run --rm --name greptimedb-dashboard \ | ||
| -e GREPTIMEDB_HTTP_HOST=127.0.0.1 \ | ||
| -e GREPTIMEDB_HTTP_PORT=4000 \ | ||
| -e NGINX_PORT=8080 \ | ||
| --network host \ | ||
| -p 8080:8080 \ | ||
| greptime/greptimedb-dashboard:latest |
There was a problem hiding this comment.
If we don't run db in docker, we can't access db in PC.
Comment on lines
6
to
8
| location /api/ { | ||
| proxy_pass http://${GREPTIMEDB_HTTP_HOST}:${GREPTIMEDB_HTTP_PORT}/; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference