Avoid warning about missing space around literal #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following warning (for PRIu64 when used in printf): "invalid suffix on literal; C++11 requires a space between literal and string macro" While just a warning on GCC, this is actually on error on Clang, and since Bioconda builds its macOS packages using Clang, Bioconda builds currently need a patch for samblaster. See bioconda/bioconda-recipes#20931 This also turns the warning into an error to avoid the problem in the future.
|
Addressed in v.0.1.26 |
marcelm
added a commit
to bioconda/bioconda-recipes
that referenced
this pull request
Jun 4, 2020
This patch is no longer necessary according to GregoryFaust/samblaster#44 (comment)
marcelm
added a commit
to bioconda/bioconda-recipes
that referenced
this pull request
Jun 4, 2020
* Update samblaster to 0.1.26 * Delete spaces_around_identifier.patch This patch is no longer necessary according to GregoryFaust/samblaster#44 (comment) * The patch is no longer needed * Update meta.yaml * Update meta.yaml Co-authored-by: Marcel Martin <marcel.martin@scilifelab.se>
a-solovyev12
pushed a commit
to ebi-gene-expression-group/bioconda-recipes
that referenced
this pull request
Jun 29, 2020
* Update samblaster to 0.1.26 * Delete spaces_around_identifier.patch This patch is no longer necessary according to GregoryFaust/samblaster#44 (comment) * The patch is no longer needed * Update meta.yaml * Update meta.yaml Co-authored-by: Marcel Martin <marcel.martin@scilifelab.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following warning (for PRIu64 when used in printf):
While just a warning on GCC, this is actually an error on Clang, and since Bioconda builds its macOS packages using Clang, Bioconda currently need a patch for samblaster.
See bioconda/bioconda-recipes#20931
This also turns the warning into an error even on GCC to avoid the problem in the future.