Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (Event): Dispatch a new PreSendEnvelopeEvent before sending the envelope to DocuSign #119

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

GregoireHebert
Copy link
Owner

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #119 (44d736c) into main (3820325) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
+ Coverage     72.05%   72.22%   +0.17%     
- Complexity      258      260       +2     
============================================
  Files            40       41       +1     
  Lines          1120     1127       +7     
============================================
+ Hits            807      814       +7     
  Misses          313      313              
Flag Coverage Δ
phpunit 72.22% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/EnvelopeCreator/SendEnvelope.php 94.11% <100.00%> (+1.26%) ⬆️
src/Events/PreSendEnvelopeEvent.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3820325...44d736c. Read the comment docs.

@GregoireHebert GregoireHebert marked this pull request as ready for review August 22, 2021 18:55
@GregoireHebert GregoireHebert merged commit cd7cf12 into main Aug 22, 2021
@GregoireHebert GregoireHebert deleted the add-event branch August 22, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant