Update Chemistry for consistancy with GTCE #388
Conversation
Update fork
|
A list of (currently) changed files, with checkboxes for if I have reviewed and finalized the chemistry in them:
|
|
With this REEChain finalization, the step: |
|
In the last commit |
|
The last commit cleans up a bunch of code in the recipes package. Mostly, it ensures that:
This kind of cleanup of the code, I would like to do over the entire codebase at some point. But for today, I only touched the recipes section since that is what this PR is working in. I was able to make some optimizations while doing this just over this small subsection of the codebase, and also found a place where I believe the functionality is broken, but I will have to test it further. |
|
For those paying loose attention to this branch, with that last commit, that means that we are done with the second phase of this PR. Now, we have one last review of a few things, mostly cleaning up some remaining TODOs and some things in GAMaterials. Nearly there! |
|
Marking this PR as Ready To Review |
|
Have you run your recipe conflict tests on this? |
|
i want to know if we can have those ore dust process in ebf back? it was add to improve duction from ores. after this change, many ore contain less elements than before. so i want more output, like more dust in one ore, or add them back |
|
Balancing those EBF recipes would make them completely equivalent to electrolysis, except that they would take the extra step in the EBF. There wouldn't be a benefit to them anymore, which is why they were removed. |
|
so can we get more crushed ores from ore? |
* Create checks on master commits * Add badges to README update required licensing information * remove gradle.properties from checks * Revert "remove gradle.properties from checks" This reverts commit 2e131db. * Add command handler Remove BuildCraftAPI as its unneeded * Update fs permission * add execution permission * Add executable bit to gradlew * remove old execution enabling
* Update zh_cn.lang * Update zn_cn.lang * update zh_cn.lang * Update zh_cn.lang * Update zh_cn.lang * Update zh_cn.lang
Introduction
This PR addresses issues in every single chain we have in the mod. We have been thorough and made sure to double or triple check every single recipe we have added to the game. Most of these adjustments were to adjust mole amounts, which I will get into later, though there was a fairly substantial amount of recipes reworked to maintain proper chemistry and avoid positive loop exploits/lossy recipes.
Conventions
As per conventions established and followed rigorously by GTCE, our mole counts follow two rules:
See GregTechCE/GregTech#1414 for the original unification of the conventions we are maintaining in this PR.
*: Some dusts have very large formulas, and some are almost completely unknown, so in these rare cases, we left them at 1 dust per mole. This is a bad thing to do, but sometimes there is just no other way. Any time this was done, it was handled very carefully to ensure no side effects.
Recipe Map Changes
As a result of this PR, we have changed the RecipeMaps for the LCR and Chemical Plant slightly, changing input/output amounts.
This allowed for some of our more complex balanced reactions to fit in a machine, and also helps differentiate the Chemical Plant from the LCR. Additionally, it will help for the future when condensed processes are eventually added to the Chemical Plant.
Material Changes
Since fluid tooltips now exist, we have implemented a way for tooltips to be provided for fluids. We have this provided as either an ImmutableList like before, or simply as a String. There is also now a way to give a tooltip to a SimpleDust as a String instead of an ImmutableList. This should be the preferred way, since it is more efficient on load time since we were not using the ImmutableList for anything other than tooltip generation anyway.
There was a fair amount of materials changed, mostly due to misspelled variable names, translation keys, and translated names. These have all been updated, but there may be some warnings on updating. As a result, the release including this PR should definitely be stated in the release notes very clearly.
Credits
Issues Closed
Closes #371
Closes #392
(both of these issues have active issues in the comments addressed in this PR, despite both of these issues being closed)