Fix ME hatches crashing on server side #2812
Merged
+25
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR distinguishes between the code in ME hatches that runs on the server and the code that runs on the client.
Implementation Details
This code contains
that should only run in client.
The method
setSlotIndex
was invoked byenableAmount
anddisableAmount
.In most cases, calls to the above two methods appear in client code with
@OnlyIn(Dist.CLIENT)
.But the method
in
AEFluidConfigSlotWidget
andAEItemConfigSlotWidget
will invoke theenableAmount
anddisableAmount
method.The server will call a code that only exists in the client then throw
NoSuchMethodError
and crash.I added client versions of
enableAmount
,disableAmount
andsetSlotIndex
then let thehandleClientAction
to invoke server version.Outcome
Fix #2805
Additional Information
Also tested in Monifactory pack.
Potential Compatibility Issues
I checked these code only exist in ME related hatched/buses.
So it seems unlikely that there is a compatibility issue.