Crafting Component Refactor #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screret
requested changes
Dec 30, 2024
docs/content/Modpacks/Other-Topics/Modifying-Crafting-Components.md
Outdated
Show resolved
Hide resolved
docs/content/Modpacks/Other-Topics/Modifying-Crafting-Components.md
Outdated
Show resolved
Hide resolved
docs/content/Modpacks/Other-Topics/Modifying-Crafting-Components.md
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java
Outdated
Show resolved
Hide resolved
screret
approved these changes
Jan 4, 2025
krossgg
added a commit
that referenced
this pull request
Jan 10, 2025
krossgg
pushed a commit
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor of the
CraftingComponentclass for better usability in addons and kubeImplementation Details
Fixed CraftingComponents to only allow
TagKey<Item>s,ItemStacks orMaterialEntriesfor each entry in the tier list, capped the list toGTValues.V.lengthand forced fallbacks when making a new crafting component(wasn't strictly needed beforehand)Also reworked and added more helper methods for KubeJS to edit and make more crafting components/fallbacks/entries in a clearer manner.
Outcome
Adding or modifying recipe components should be simpler now
Potential Compatibility Issues
Kube scripts will have to update is they use or make crafting components for recipes, class path changing as well occurred.