KubeJS builder refactor #2574
Merged
KubeJS builder refactor #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed erroneusly in KJS coil blocks
… aligned to how we do it in java
jtuc
reviewed
Dec 17, 2024
src/main/java/com/gregtechceu/gtceu/common/item/ItemMagnetBehavior.java
Outdated
Show resolved
Hide resolved
krossgg
requested changes
Dec 17, 2024
src/main/java/com/gregtechceu/gtceu/api/registry/registrate/MultiblockMachineBuilder.java
Outdated
Show resolved
Hide resolved
krossgg
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
removes the varargs objects for machine tiers and elements, and cleans up the whole thing.
machines now pass the tiers in a method and the modification to specific builders is applied via a lambda in
definition((tier, builder) => ...)multiblocks with a single tier will stay the same. ones with multiple tiers will use the same paradigm as singleblocks, but with a different type.
elements, which also used this system, will now just set all the parameters via a builder pattern.
Implementation Details
GTRegistryEventJSRendererBlockItemclass as we didn't use it anywhere except erroneously in the coil block builder.Outcome
better machine registration on the java side, much cleaner code
Additional Information
example.zip