Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutter cover exposing item and fluid handlers #2572

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

omergunr100
Copy link
Contributor

@omergunr100 omergunr100 commented Dec 17, 2024

What

When a machine has a shutter cover the side shouldn't expose an item/fluid handler.

Implementation Details

Override the get capabilities methods on the shutter cover.

Outcome

Fixes #2542

@omergunr100 omergunr100 requested a review from a team as a code owner December 17, 2024 10:13
@screret
Copy link
Member

screret commented Dec 17, 2024

does toggling the cover still work?

@omergunr100
Copy link
Contributor Author

Honestly I didn't even know this cover was toggleable, I thought you place it where you don't want the machine to expose the handlers.
I'll fix that.

@omergunr100
Copy link
Contributor Author

image
found another issue while testing it :trollface:

@krossgg krossgg added the type: bugfix general bug fixes label Dec 19, 2024
@screret screret merged commit c6fa263 into GregTechCEu:1.20.1 Dec 19, 2024
4 of 5 checks passed
@omergunr100 omergunr100 deleted the 1.20.1-shutter-cover-fix branch December 19, 2024 08:30
@tomprince
Copy link
Contributor

I can confirm that I can use a shutter in the location which prompted the issue. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix general bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shutter over next to AE2's Molecular assembler doesn't block input.
4 participants