Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncreate Create Compat. #2546

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Uncreate Create Compat. #2546

merged 3 commits into from
Dec 15, 2024

Conversation

Ghostipedia
Copy link
Member

What

Removes All Create Compat, RecipeCaps and all things related to Create from GTCEU:Modern

Implementation Details

Right Click, Delete File
Highlight Line, Delete File

Outcome

No More Create :)

Potential Compatibility Issues

All Devs relying on KubeJS or Mod Compat with the Create Mixins and Functionality inside of GTCEU:MODERN Will need to do one of the following

  • Take the Old Code Removed in this PR and make their own addon. You are now entirely responsible for making your Create Compat good and stable as the initial implementation inside of GTM should have never existed to begin with and was riddled with longstanding bugs and compat issues.

Additional Information

i was at house, eating chicken... when phone ring...
"Create compatibility is kil"
"Yes..."
366323089-506e888e-af82-43a2-a262-bce5e9495400

@screret
Copy link
Member

screret commented Dec 14, 2024

Highlight Line, Delete File

buddy

@Ghostipedia
Copy link
Member Author

Still working on this, spotless will fail, double checking i got everything

@krossgg krossgg added the type: refactor Suggestion to refactor a section of code label Dec 14, 2024
@Ghostipedia Ghostipedia marked this pull request as ready for review December 14, 2024 22:19
@Ghostipedia Ghostipedia requested a review from a team as a code owner December 14, 2024 22:19
@Spicierspace153
Copy link
Contributor

discord ping

modern dev talks
create is kill
approved

@JuiceyBeans
Copy link
Contributor

i was at house, eating ice cream... when discord ping...
"Create compatibility is kil"
"Yes..."

@GregTechCEu GregTechCEu locked as off-topic and limited conversation to collaborators Dec 14, 2024
Copy link
Member

@screret screret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see anything errant at least

@Ghostipedia
Copy link
Member Author

If we find anything outstanding in the future or unused method in the main code. Ig just doublecheck if it was related to this and append it here for any future addon devs that may need it. Going to merge this now.

@Ghostipedia Ghostipedia merged commit a8502bf into 1.20.1 Dec 15, 2024
3 checks passed
@Ghostipedia Ghostipedia deleted the gp/uncreate branch December 15, 2024 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants