Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to machine magnetized materials into magnetic parts #2355

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

YoungOnionMC
Copy link
Member

@YoungOnionMC YoungOnionMC commented Nov 14, 2024

What

Edits all part handling recipes so that magnetic materials return the non magnetized version, forcing the polarizer to make magnetic parts
fixes #1681

Implementation Details

Any part handler checks if that material is magnetic, if so use the macerate material

Outcome

Gives the polarizer a more foundational use in progression

Potential Compatibility Issues

Any ae recipes will need to be edited

@YoungOnionMC YoungOnionMC requested a review from a team as a code owner November 14, 2024 22:49
@YoungOnionMC YoungOnionMC added the type: feature New feature or request label Nov 17, 2024
@krossgg krossgg added the type: refactor Suggestion to refactor a section of code label Nov 17, 2024
@krossgg krossgg changed the title Polarizer magnetism Remove ability to machine magentized materials into magnetic formed parts Nov 17, 2024
@krossgg krossgg changed the title Remove ability to machine magentized materials into magnetic formed parts Remove ability to machine magentized materials into magnetic parts Nov 17, 2024
@YoungOnionMC YoungOnionMC merged commit 58184a9 into 1.20.1 Nov 17, 2024
4 checks passed
@YoungOnionMC YoungOnionMC deleted the yo/demagnetize branch November 17, 2024 09:26
@YoungOnionMC YoungOnionMC removed the type: feature New feature or request label Nov 25, 2024
@YoungOnionMC YoungOnionMC changed the title Remove ability to machine magentized materials into magnetic parts Remove ability to machine magnetized materials into magnetic parts Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magnetic materials shouldn't be obtainable from any machine other than a polarizer
2 participants