Add waypoint creation in the prospector #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoungOnionMC
approved these changes
Nov 13, 2024
krossgg
approved these changes
Nov 13, 2024
screret
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: YoungOnion <39562198+YoungOnionMC@users.noreply.github.com>
screret
pushed a commit
that referenced
this pull request
Dec 28, 2024
Co-authored-by: YoungOnion <39562198+YoungOnionMC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the ability to click to set a waypoint as described in #1821. The issue was closed because the ability to see the veins was implemented on the map but not actual waypoints that show in world if the player clicks inside the prospector.
Additional Information
Xaero waypoints seem to be somewhat broken in that they don't show up in it's waypoint manager and can't be deleted. This is an issue with the waypoint integration so I didn't fix it in this PR.
Also this implementation isn't the exact same as the 1.12 version. I added logic to get the exact clicked ore instead of just using the tooltip's name.